Search Linux Wireless

Re: [PATCH 1/1] mac80211: [RFC] do not fragment while aggregation is in use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks.

> -	/*
> -	 * Warn when submitting a fragmented A-MPDU frame and drop it.
> -	 * This is an error and needs to be fixed elsewhere, but when
> -	 * done needs to take care of monitor interfaces (injection)
> -	 * etc.
> -	 */
> -	if (WARN_ON(tx->flags & IEEE80211_TX_CTL_AMPDU ||
> -		    skb_get_queue_mapping(tx->skb) >=
> -			ieee80211_num_regular_queues(&tx->local->hw)))
> -		return TX_DROP;
> -

Should we keep that, just in case? If it ever happens and the hw rejects
a fragment for some reason, we'll otherwise clobber some state and
probably crash.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux