> -----Original Message----- > From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Sent: 2017年4月4日 2:42 > To: Dmitry Torokhov > Cc: Xinming Hu; Linux Wireless; Kalle Valo; Rajat Jain; Amitkumar Karwar; Cathy > Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 2/3] mwifiex: using general print function during > device intialization > > External Email > > ---------------------------------------------------------------------- > On Fri, Mar 31, 2017 at 03:46:58PM -0700, Dmitry Torokhov wrote: > > On Thu, Mar 30, 2017 at 2:19 AM, Xinming Hu <huxinming820@xxxxxxxxx> > wrote: > > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > > > adapter->dev is initialized after mwifiex_register done, before that > > > print message by general pr_* function > > > > No, we should move away from naked pr_*() as much as possible. Please > > change mwifiex_register() to accept "dev" parameter and assign > > adapter->dev early enough so that the standard mwifiex_err() calls are > > usable. > Thanks for the review. > Agreed. You mean like I did here? :) > > ba1c7e45ec22 mwifiex: set adapter->dev before starting to use mwifiex_dbg() > > That's in v4.11-rc4, partly as a bugfix to this: > > 2e02b5814217 ("mwifiex: Allow mwifiex early access to device structure") > > > Also consider changing _mwifiex_dbg() to handle cases when > > adapter->dev is NULL and fall back to pr_<level>. > > That'd be nice. It would have mitigated the problems of commit > 2e02b5814217 too. > Yes, this commit ba1c7e4 should be better and work for most cases, will enhance __mwifiex_dbg for adapter->dev NULL case in V2. Thanks, Simon > Brian > > > > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > > --- > > > drivers/net/wireless/marvell/mwifiex/pcie.c | 78 > > > ++++++++++++----------------- > > > drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +- > > > 2 files changed, 34 insertions(+), 47 deletions(-) > > [...]
