Hi Brain, > -----Original Message----- > From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Sent: 2017年4月4日 2:34 > To: Dmitry Torokhov > Cc: Xinming Hu; Linux Wireless; Kalle Valo; Rajat Jain; Amitkumar Karwar; Cathy > Luo; Xinming Hu > Subject: [EXT] Re: [PATCH 1/3] mwifiex: remove unnecessary wakeup interrupt > number sanity check > > External Email > > ---------------------------------------------------------------------- > On Fri, Mar 31, 2017 at 03:37:01PM -0700, Dmitry Torokhov wrote: > > On Thu, Mar 30, 2017 at 2:19 AM, Xinming Hu <huxinming820@xxxxxxxxx> > wrote: > > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > > > Sanity check of interrupt number in interrupt handler is unnecessary > > > and confusion, remove it. > > > > I'd reworded the explanation a bit: "If wakeup interrupt handler is > > called, we know that the wakeup interrupt number is valid, there is no > > need to check it." > > Either way works for me (modulo grammar), though Dmitry's is more > informative. So +1. > > > Otherwise: > > > > Reviewed-by: Dmitry Torokhov <dtor@xxxxxxxxxxxx> > > Ooh, me too! > > Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > I believe this same pattern occurs in btmrvl_sdio. Possibly others. > Thanks for the review, the similar change have been applied to Bluetooth(commit 733db4ccec) Thanks SImon > > > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > > --- > > > drivers/net/wireless/marvell/mwifiex/main.c | 8 +++----- > > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/main.c > > > b/drivers/net/wireless/marvell/mwifiex/main.c > > > index 30f4994..5e82602 100644 > > > --- a/drivers/net/wireless/marvell/mwifiex/main.c > > > +++ b/drivers/net/wireless/marvell/mwifiex/main.c > > > @@ -1503,11 +1503,9 @@ static irqreturn_t > > > mwifiex_irq_wakeup_handler(int irq, void *priv) { > > > struct mwifiex_adapter *adapter = priv; > > > > > > - if (adapter->irq_wakeup >= 0) { > > > - dev_dbg(adapter->dev, "%s: wake by wifi", __func__); > > > - adapter->wake_by_wifi = true; > > > - disable_irq_nosync(irq); > > > - } > > > + dev_dbg(adapter->dev, "%s: wake by wifi", __func__); > > > + adapter->wake_by_wifi = true; > > > + disable_irq_nosync(irq); > > > > > > /* Notify PM core we are wakeup source */ > > > pm_wakeup_event(adapter->dev, 0); > > > -- > > > 1.8.1.4 > > >
