On 15-2-2017 10:16, Johannes Berg wrote: > On Wed, 2017-02-15 at 10:08 +0100, Arend Van Spriel wrote: >> [snip] >> >> Looks good to me. > > Thanks for checking :) > >>> + /* not covered or invalid combination received */ >> >> Do you want to inform about the invalid/reserved combination. > > I'm not really sure what to do - we don't really want to print a > message on something that might have been received from the peer, I > think? Though I suppose we should return 0 for the invalid > combinations, indicating that they're not supported. Ah. This is all non-functional code yet, right? At least having a static non-inline function in ieee80211.h will give build issues I would think. Anyway, I would indeed return 0 and have caller deal with that. Regards, Arend
