On 8 January 2017 at 14:00, Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote: > On 7-1-2017 21:36, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@xxxxxxxxxx> >> >> During bands setup we disable all channels that firmware doesn't support >> in the current regulatory setup. If we do this before wiphy_register >> it will result in copying set flags (including IEEE80211_CHAN_DISABLED) >> to the orig_flags which is supposed to be persistent. We don't want this >> as regulatory change may result in enabling some channels. We shouldn't >> mess with orig_flags then (by changing them or ignoring them) so it's >> better to just take care of their proper values. >> >> This patch cleanups code a bit (by taking orig_flags more seriously) and >> allows further improvements like disabling really unavailable channels. >> We will need that e.g. if some frequencies should be disabled for good >> due to hardware setup (design). > > I think this and previous patch are too dependent and prefer to have > them in a single patch. Despite that for both: > > Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> This time to make sure I can be easily understood I decided to use two smaller patches & describe each of them with all the details that came to my mind. I also made sure (and described that) that applying only 1/2 won't break anything (we never wan't to break potential bisecting process). I can work on merging (squashing) these 2 patches but then I need to rework commit messages & I'll risk someone will say my description isn't clear enough or my patch is too complex... If there isn't a real problem (and maybe having 2 patches makes following changes more easily) maybe let's stick to this patchset? -- Rafał
