On Thu, Dec 01, 2016 at 07:48:24PM -0600, Larry Finger wrote: > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > index 2d48ccd..0f9d9f0 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c > @@ -731,6 +731,14 @@ void rtl92ee_tx_fill_desc(struct ieee80211_hw *hw, > SET_TX_DESC_OFFSET(pdesc, USB_HWDESC_HEADER_LEN); > } > > + /* tx report */ > + if (ptcb_desc->use_spe_rpt) { > + u16 sn = rtl_get_tx_report_sn(hw); > + > + SET_TX_DESC_SPE_RPT(pdesc, 1); > + SET_TX_DESC_SW_DEFINE(pdesc, sn); > + } > + All the callers of rtl_get_tx_report_sn() use this same 5 line block. Let's move it to a separate function. regards, dan carpenter