On Thu, Dec 01, 2016 at 07:48:21PM -0600, Larry Finger wrote: > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > There is a potential race condition when the control byte of a CAM > entry is written first. Write in reverse order to correct the condition. > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Signed-off-by: shaofu <shaofu@xxxxxxxxxxx> > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > --- > drivers/net/wireless/realtek/rtlwifi/cam.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/cam.c b/drivers/net/wireless/realtek/rtlwifi/cam.c > index 8fe8b4c..5d58ec0 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/cam.c > +++ b/drivers/net/wireless/realtek/rtlwifi/cam.c > @@ -45,12 +45,13 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no, > > u32 target_command; > u32 target_content = 0; > - u8 entry_i; > + s8 entry_i; Just make this an int. s8 is for very specific things like hardware registers. regards, dan carpenter
