Search Linux Wireless

Re: [PATCH] wireless.h: improve userland include-ability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2008-06-03 at 12:05 -0700, David Miller wrote:
> Yeah, go check so me magic userspace tool header to see what magic is
> needed just to include a core networking header file correctly.
> 
> No, thanks.

Just to clarify: this is only a problem for userspace, and you're
objecting to that? Just including <linux/wireless.h> within the kernel
will continue to work.

We've traditionally got away with saying 'caveat emptor' when userspace
includes kernel headers -- you _have_ to include the right
prerequisites, because the kernel doesn't do it for you.

I'm happy enough to change that, but it means seeing stuff like...
	#ifndef __KERNEL__
	#include <sys/foo.h>
	#endif 
... in kernel headers. Is that what you're intending, or am I
misunderstanding your objection?

I believe that the main reason for this patch was that <linux/socket.h>
and <linux/if.h> both have problems when you include them in the same C
file as the 'proper' glibc equivalent? Is that something we can address,
instead of just dropping those includes?

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux