From: "John W. Linville" <linville@xxxxxxxxxxxxx>
Date: Tue, 3 Jun 2008 13:51:37 -0400
> From: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
>
> This patch partially reverts commit 2218228392080f0ca2fc2974604e79f57b12c436
> ("Make linux/wireless.h be able to compile") while still making it
> easier to include wireless.h in userland apps.
>
> Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
I not thrilled about this patch.
This means the user has to figure out what include file to add
to get IFNAMSIZ and things like that which wireless.h needs.
That is non-intuitive and magic. These headers should be entirely
self-contained so that if you include linux/wireless.h it should
just work and there should be no dependencies not handlind by
wireless.h doing the necessary includes.
+/* This header is used in user-space, therefore need to be sanitised
+ * for that purpose. Those includes are usually not compatible with glibc.
+ * To know which includes to use in user-space, check iwlib.h. */
Yeah, go check so me magic userspace tool header to see what magic is
needed just to include a core networking header file correctly.
No, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
