> * the nl80211 feature flags for the device. > + * @NL80211_SCAN_FLAGS_IE_DATA: request the device to supply IE data > in the > + * request. What does that mean? > + * @NL80211_GSCAN_CHAN_ATTR_NO_IR: scanning should be done passive. why not call that passive? No-IR is something we use in regulatory code to be more generic than "passive" (since it's also about beaconing etc.) but here? > + * @NL80211_GSCAN_CHAN_ATTR_MAX: highest GScan channel attribute. Generally, you should also document the attribute types here (and everywhere else really) > + NL80211_BUCKET_BAND_2GHZ = (1 << 0), no need for parentheses with enums :) > + if (tb[NL80211_GSCAN_CHAN_ATTR_DWELL_TIME]) > + chan->dwell_time = > nla_get_u32(tb[NL80211_GSCAN_CHAN_ATTR_DWELL_TIME]); Maybe that should have some kind of "reasonable range" limit? So I mostly looked at this from a pure code POV - need to compare with our implementation, but I guess the basis is the same ... johannes
