Search Linux Wireless

Re: [WEXT 8/12]: Pull top-level ioctl dispatch logic into helper function.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Masakazu Mokuno <mokuno@xxxxxxxxxxxxx>
Date: Mon, 21 Jan 2008 20:16:19 +0900

I am working on these patches again, thank you for your
extreme patience...

> > +int wext_handle_ioctl(struct net *net, struct ifreq *ifr, unsigned int cmd,
> > +		      void __user *arg)
> > +{
> > +	int ret = wext_ioctl_dispatch(net, ifr, cmd,
> > +				      ioctl_standard_call,
> > +				      ioctl_private_call);
> > +
> > +	if (ret > 0 &&
> 
> As the return value 0 is legal, should we allow copybacking in the case
> of 'ret == 0'?
> 
> Same issue exists in compat_wext_handle_ioctl() of the #9 patch.

You are right, I wonder why I made this strange test.  It should
definitely be "ret >= 0".  I'll make that fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux