Hi Dave,
On Fri, 21 Dec 2007 20:56:23 -0800 (PST)
David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> [WEXT]: Pull top-level ioctl dispatch logic into helper function.
>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
<snip>
> +int wext_handle_ioctl(struct net *net, struct ifreq *ifr, unsigned int cmd,
> + void __user *arg)
> +{
> + int ret = wext_ioctl_dispatch(net, ifr, cmd,
> + ioctl_standard_call,
> + ioctl_private_call);
> +
> + if (ret > 0 &&
As the return value 0 is legal, should we allow copybacking in the case
of 'ret == 0'?
Same issue exists in compat_wext_handle_ioctl() of the #9 patch.
> + IW_IS_GET(cmd) &&
> + copy_to_user(arg, ifr, sizeof(struct iwreq)))
> return -EFAULT;
> +
> return ret;
> }
--
Masakazu MOKUNO
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
