On 11-8-2016 14:48, Johannes Berg wrote: > On Wed, 2016-08-10 at 12:33 +0200, Arend van Spriel wrote: >> The wrapper rdev_set_coalesce() checks whether the driver provides >> the set_coalesce callback and returns -ENOTSUPP if not. However, this >> check is already performed in nl80211_set_coalesce() resulting in >> -EOPNOTSUPP. This patch removes check from rdev wrapper function. > > What's the point though? Presumably the compiler will optimise it out, > and it seems safer to have it this way? Same for all patches in this > series. I was in doubt to raise the question first about getting this stuff consistent, ie. keep rdev-ops as flat as possible, but decided just to put it out there in patch format. My bad :-) If you want the rdev-ops to be safe against (future) callers not checking the callback, it seems you should add a check in all rdev-ops where the callback is optional. Regards, Arend -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
