>What if you have AP,GO,mesh in the same interface combination? Either your documentation needs to very very clearly state that the mesh must match (either one of them?) and I'd go as far as >renaming the APIs, or you shouldn't require multiple APs and make this apply on mesh and IBSS as well. I guess , we can extend this to mesh and IBSS as well. >It seems to me that if I were to specify beacon intervals which have a very small GCD, you'll run into trouble when actually sending beacons. >Perhaps there should be a requirement on the GCD? Can we have this published by the host drivers through a new wiphy parameter , say "min_diff_beacon_interval_multiplier". This set's the expectation that any different beacon intervals on the wiphy shall be a multiple of this parameter which is advertised by the host driver , isn't ? Regards, Sunil -----Original Message----- From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] Sent: Friday, August 5, 2016 2:19 PM To: Kushwaha, Purushottam <pkushwah@xxxxxxxxxxxxxxxx> Cc: linux-wireless@xxxxxxxxxxxxxxx; Malinen, Jouni <jouni@xxxxxxxxxxxxxxxx>; Undekari, Sunil Dutt <usdutt@xxxxxxxxxxxxxxxx>; Kondabattini, Ganesh <ganeshk@xxxxxxxxxxxxxxxx>; Kalikot Veetil, Mahesh Kumar <mkalikot@xxxxxxxxxxxxxxxx>; Hullur Subramanyam, Amarnath <amarnath@xxxxxxxxxxxxxxxx> Subject: Re: [PATCH v4] cfg80211: Provision to allow the support for different beacon intervals On Fri, 2016-08-05 at 10:56 +0530, Purushottam Kushwaha wrote: > This commit provides the option for the host drivers to advertise the > support for different beacon intervals among the respective interface > combinations, through supp_diff_beacon_int (bool). Neither your commit message nor the documentation makes a direct reference to this affecting only AP/GO interface. However, you then go and require that at least 2 interfaces with AP/GO are present. What if you have AP,GO,mesh in the same interface combination? Either your documentation needs to very very clearly state that the mesh must match (either one of them?) and I'd go as far as renaming the APIs, or you shouldn't require multiple APs and make this apply on mesh and IBSS as well. Are there really no restrictions whatsoever, btw? It seems to me that if I were to specify beacon intervals which have a very small GCD, you'll run into trouble when actually sending beacons. Perhaps there should be a requirement on the GCD? johannes ��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
