On 07/19/2016 02:20 AM, Arend Van Spriel wrote: > + Bob > > On 19-7-2016 1:24, Florian Fainelli wrote: >> Hi, >> >> This patch series addresses several coverity issues, they all seemed relevant >> to me. > > Hi Florian, > > Been a while so nice to see coverity fixes popping up. Actually > something that I have on my todo list to add our brcm80211 to coverity > within Broadcom. So being curious as to whether this comes from a public > coverity server like scan.coverity.com. Maybe bit redundant to setup > internally if there is a good coverity analysis publicly available. This is coming from the public coverity instance, if you create an account there I could transfer to you the other bugs that affect the brcm80211 drivers (hint: there is a ton of of them because of brcmf_fil_iovar_int_get and friends). > >> There is also a ton of warnings in Coverity caused by brcmf_fil_iovar_int_get() >> and friends because of the initial access: >> >> __le32 data_le = cpu_to_le32(*data) which can utilize unitialized memory. I am >> not sure if we actually care about any kind of initial, value, but if we don't, >> then the fix should be fairly obvious. > > If we are talking only about "get" variant than we mostly don't care. > Some getters support filter variables to be passed towards firmware. I > have not looked at the analysis to give any judgement here. Alright, do you have a good way to test a patch that would just zero initialize the data variable in brcmf_fil_iovar_int_get()? If so, I will submit one with the appropriate CID references. Thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
