+ Bob On 19-7-2016 1:24, Florian Fainelli wrote: > Hi, > > This patch series addresses several coverity issues, they all seemed relevant > to me. Hi Florian, Been a while so nice to see coverity fixes popping up. Actually something that I have on my todo list to add our brcm80211 to coverity within Broadcom. So being curious as to whether this comes from a public coverity server like scan.coverity.com. Maybe bit redundant to setup internally if there is a good coverity analysis publicly available. > There is also a ton of warnings in Coverity caused by brcmf_fil_iovar_int_get() > and friends because of the initial access: > > __le32 data_le = cpu_to_le32(*data) which can utilize unitialized memory. I am > not sure if we actually care about any kind of initial, value, but if we don't, > then the fix should be fairly obvious. If we are talking only about "get" variant than we mostly don't care. Some getters support filter variables to be passed towards firmware. I have not looked at the analysis to give any judgement here. Regards, Arend > Thanks! > > > Florian Fainelli (4): > brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain > brcmsmac: Free packet if dma_mapping_error() fails in dma_rxfill > brcmsmac: Fix invalid memcpy() size in brcms_c_d11hdrs_mac80211 > brcmsmac: Initialize power in brcms_c_stf_ss_algo_channel_get() > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +++- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c | 4 +++- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 2 +- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/stf.c | 2 +- > 4 files changed, 8 insertions(+), 4 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
