Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > Hi Kalle, > >> -----Original Message----- >> From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] >> Sent: Wednesday, July 13, 2016 9:20 PM >> To: Amitkumar Karwar >> Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam >> Subject: Re: [PATCH v3 1/2] mwifiex: add manufacturing mode support >> >> Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: >> >> > By default normal mode is chosen when driver is loaded. This patch >> > adds a provision to choose manufacturing mode via module parameters. >> > >> > Command to load driver in manufacturing mode insmod mwifiex.ko >> > mfg_mode=1 and mfg_firmware=mrvl/firmware. >> > >> > Tested-by: chunfan chen <jeffc@xxxxxxxxxxx> >> > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> >> >> Why the mfg_firmware module parameter? > > It's to specify a firmware name. Yeah, I got that. But why do you need that? Why not just hardcode the firmware name in the driver, which is the normal thing to do? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
