Hi Kalle, > -----Original Message----- > From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > Sent: Wednesday, July 13, 2016 9:18 PM > To: Amitkumar Karwar > Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > Xinming Hu > Subject: Re: [PATCH v3 2/2] mwifiex: add hostcmd wext ioctl support > > Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > > > Hi Kalle, > > > >> -----Original Message----- > >> From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx] > >> Sent: Wednesday, July 13, 2016 8:44 PM > >> To: Amitkumar Karwar > >> Cc: linux-wireless@xxxxxxxxxxxxxxx; Cathy Luo; Nishant Sarmukadam; > >> Xinming Hu > >> Subject: Re: [PATCH v3 2/2] mwifiex: add hostcmd wext ioctl support > >> > >> Amitkumar Karwar <akarwar@xxxxxxxxxxx> writes: > >> > >> > From: Xinming Hu <huxm@xxxxxxxxxxx> > >> > > >> > This patch adds ndo_ioctl support to mwifiex netdev handlers. > >> > This will be used to download hostcmds to firmware from userspace. > >> > This is needed for manufacturing mode support in mwifiex. ndo_ioctl > >> > is allowed only when mfg mode is enabled via module load > parameters. > >> > > >> > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > >> > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > >> > --- > >> > v3: Add "select WIRELESS_EXT" in Kconfig to resolve kbuild test > >> > robot > >> errors. > >> > WEXT_PRIV seems to have a dependency with WIRELESS_EXT. > >> > v2: 1) Sequence of these two patches are changed to resolve > >> compilation > >> > error seen if only 1/2 is applied. > >> > 2) Add "select WEXT_PRIV" in Kconfig to resolve warnings > >> > reported > >> by > >> > kbuild test robot. > >> > >> Why can't you use nl80211 testmode interface? > > > > These two patches facilitates user to configure manufacturing mode. We > > have a separate firmware for this mode. It's needed to run special > > WiFi conductive and radiated tests at factory. > > This is exactly what nl80211 testmode is for. > > > The userspace tools used for this purpose expects WEXT interface. > > So convert them to use nl80211. I have done that myself, multiple times > actually. > > And for wireless extensions, from my point of view it's dead and buried. > I'm not going to take any new wireless extension related code. Thanks for your feedback. We will change the tools and prepare driver patch using nl80211 testmode. Regards, Amitkumar -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
