I am not sure it works fine. Like ath6kl driver send another cmd to firmare, I have just filled up the cmd buffer with "tx_ant", and "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd buffer to firmware. I have resend the patch as there are some errors in the previous patch. Let me know if any modifications are needed? On Wed, Jun 8, 2016 at 8:16 PM, Valo, Kalle <kvalo@xxxxxxxxxxxxxxxx> wrote: > Prasun Maiti <prasunmaiti87@xxxxxxxxx> writes: > >> No. I did not any test for that case. >> This driver create a new wiphy for use with cfg80211 through >> "wiphy_new_nm" api, but in this api, I found that more warnings for >> inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && >> !ops->get_antenna);" >> So, warning comes during creation of a new wiphy. That's why It is needed. > > I'm confused. Are you really saying that you added a new firmware > command (WMI_SET_ANTENNA_CMDID) to ath6kl but you didn't test it in any > way? How do you know that it works then? > > -- > Kalle Valo -- Thanks, Prasun -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
