No. I did not any test for that case. This driver create a new wiphy for use with cfg80211 through "wiphy_new_nm" api, but in this api, I found that more warnings for inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna && !ops->get_antenna);" So, warning comes during creation of a new wiphy. That's why It is needed. On Wed, Jun 8, 2016 at 7:53 PM, Valo, Kalle <kvalo@xxxxxxxxxxxxxxxx> wrote: > Prasun Maiti <prasunmaiti87@xxxxxxxxx> writes: > >> Since add more warnings for inconsistent ops in cfg80211, the wireless >> core warns if a driver implements a cfg80211 callback but doesn't >> implements the inverse operation. The ath6kl driver implements a cfg80211 >> .get_antenna operation handler but doesn't have the inverse .set_antenna >> callback. So, it makes warning. >> >> To remove this warning, add .set_antenna callback in ath6kl driver and >> also send a cmd to firmware with it's values. >> >> Signed-off-by: Prasun Maiti <prasunmaiti87@xxxxxxxxx> > > Did you test this? What hardware and firmware version? > > -- > Kalle Valo -- Thanks, Prasun -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
