David, On Tue, May 20, 2008 at 7:11 AM, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote: > On Sat, 2008-05-17 at 21:01 -0700, Javier Cardona wrote: >> + /* A too small boot time will result in the device booting into >> + * standalone (no-host) mode before the host can take control of it, >> + * so the change will be hard to revert. This may be a desired >> + * feature (e.g to configure a very fast boot time for devices that >> + * will not be attached to a host), but dangerous. So I'm enforcing a >> + * lower limit of 20 seconds: remove and recompile the driver if this >> + * does not work for you. >> + */ >> + datum = (datum < 20) ? 20 : datum; > > Hm. The driver should be able to cope with a device which is already > booted -- it sends it a reset command and then initialises it. I don't > think we have to be so paranoid, do we? If there's a lower limit on the > boottime, it would be the time it takes for an already-active driver to > react when the device resets. Which is much less than 20 seconds. If the boottime is set smaller than the host boot time, the device will transition into standalone mode before it is detected by the host. The only recovery when that happens is to either reset the device via an external reset line or to re-insert it. That lower boundary was just intended to avoid support issues of users seeing their devices disappear after a reboot. Javier -- Javier Cardona cozybit Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
