On Fri, May 6, 2016 at 4:53 AM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Christian Daudt <csd@xxxxxxxxxxxx> writes: > >> When chip attach fails, brcmf_sdiod_intr_unregister is being called >> but that is too early as sdiodev->settings has not been set yet >> nor has brcmf_sdiod_intr_register been called. >> Change to use oob_irq_requested + newly created sd_irq_requested >> to decide on what to unregister at intr_unregister time. >> >> Steps to reproduce problem: >> - modprobe brcmfmac using buggy FW >> - rmmod brcmfmac >> - modprobe brcmfmac again. >> >> If done with a buggy firmware, brcm_chip_attach will fail on the >> 2nd modprobe triggering the call to intr_unregister and the >> kernel oops when attempting to de-reference sdiodev->settings->bus.sdio >> which has not yet been set. >> >> Signed-off-by: Christian Daudt <csd@xxxxxxxxxxxx> > > Please use prefix "brcmfmac: " in the title. > I'll resubmit with that mod after getting round 1 feedback. I was a bit rusty on patch submissions and forgot about that part on the first one. Thanks, csd -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
