On Sat, Apr 23, 2016 at 3:48 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Sat, 2016-04-23 at 02:32 +0530, Krishna Chaitanya wrote: >> On Sat, Apr 23, 2016 at 12:59 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: >> > >> > >> > On Fri, 2016-04-22 at 17:51 +0530, Krishna Chaitanya wrote: >> > > >> > > What is the recommended method for adding >> > > debug prints in mac80211 based drivers. >> > > >> > > 1) -DDEBUG + pr_debug ==> used by mac80211, brcm80211 >> > > 2) -DDEBUG + dev_dbg ==> zd1201 >> > > 3) dev_printk(KERN_DEBUG) ==> used by iwlwifi >> > > 4) printk(KERN_DEBUG) ==> Just to complete the list. >> > wiphy_dbg -> netif_dbg -> netdev_dbg -> dev_dbg -> pr_debug >> Ok, thats what checpatch --strict throws. but still different vendors >> follow >> different standards, so wanted to check if we should go strictly with >> checkpatch (or) is there any rationale behind choose each of the >> variant. > > Generally the variants are used to produce sufficient > logging information to identify the appropriate device. > > Most all debugging printks shouldn't be emitted unless > actually debugging. > >> > and CONFIG_DYNAMIC_DEBUG, no -DDEBUG required >> Yes, i understand. Till now we had this enabled, so pr_debug >> works just fine, but now it is disabled hence the question. >> >> Also there are pros and cons to having control using dyndbg, >> user can disable dyndbg, there be missing imp > > imp? Sorry, important. >> debugs, in this case >> having module level (-DDEBUG) helps but if we want entire system >> to run in non-debug mode, disabling dyndbg helps. > > Confused: > > dynamic debug printks aren't emitted by default > unless DEBUG is also defined or specifically > enabled by the user. I don't think so, enabling dynamic debug should suffice. 280 #if defined(CONFIG_DYNAMIC_DEBUG) 281 /* dynamic_pr_debug() uses pr_fmt() internally so we don't need it here */ 282 #define pr_debug(fmt, ...) \ 283 dynamic_pr_debug(fmt, ##__VA_ARGS__) 284 #elif defined(DEBUG) 285 #define pr_debug(fmt, ...) \ 286 printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) 287 #else 288 #define pr_debug(fmt, ...) \ 289 no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) 290 #endif -- Thanks, Regards, Chaitanya T K. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
