On Sat, Apr 23, 2016 at 12:59 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > > On Fri, 2016-04-22 at 17:51 +0530, Krishna Chaitanya wrote: > > What is the recommended method for adding > > debug prints in mac80211 based drivers. > > > > 1) -DDEBUG + pr_debug ==> used by mac80211, brcm80211 > > 2) -DDEBUG + dev_dbg ==> zd1201 > > 3) dev_printk(KERN_DEBUG) ==> used by iwlwifi > > 4) printk(KERN_DEBUG) ==> Just to complete the list. > > wiphy_dbg -> netif_dbg -> netdev_dbg -> dev_dbg -> pr_debug Ok, thats what checpatch --strict throws. but still different vendors follow different standards, so wanted to check if we should go strictly with checkpatch (or) is there any rationale behind choose each of the variant. > and CONFIG_DYNAMIC_DEBUG, no -DDEBUG required Yes, i understand. Till now we had this enabled, so pr_debug works just fine, but now it is disabled hence the question. Also there are pros and cons to having control using dyndbg, user can disable dyndbg, there be missing imp debugs, in this case having module level (-DDEBUG) helps but if we want entire system to run in non-debug mode, disabling dyndbg helps. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
