On Wed, 2016-04-20 at 15:30 +0000, Grumbach, Emmanuel wrote: > Hi Ben, > > > Thanks for looking at our code. > > > On Wed, 2016-04-20 at 16:08 +0100, Ben Hutchings wrote: > > > > I'm not sure if you were aware, but there is a standard API for > > configuring RSS in network drivers, part of ethtool_ops. I think > > iwlwifi should implement that rather than a driver-specific debugfs > > interface. > > > You are right, this is why Sara made this commit: > > commit 854d773e4ab5869200004af4ca5d851730849903 > Author: Sara Sharon <sara.sharon@xxxxxxxxx> > Date: Tue Mar 22 15:55:58 2016 +0200 > > iwlwifi: mvm: improve RSS configuration > > Improve current RSS configuration: > * Use netdev_rss_key instead of keeping a local copy. > * Configure also UDP hashing to have UDP traffic spread across queues. > * Do not direct RSS traffic to our fallback queue. > > Signed-off-by: Sara Sharon <sara.sharon@xxxxxxxxx> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> That doesn't really address what I said. Yes, it's using the common RSS key, but it's not implementing the ethtool operations to get and set the indirection table and the types of flow hashing that are enabled. Ben. -- Ben Hutchings Never attribute to conspiracy what can adequately be explained by stupidity.
Attachment:
signature.asc
Description: This is a digitally signed message part
