Hi Ben,
Thanks for looking at our code.
On Wed, 2016-04-20 at 16:08 +0100, Ben Hutchings wrote:
> I'm not sure if you were aware, but there is a standard API for
> configuring RSS in network drivers, part of ethtool_ops. I think
> iwlwifi should implement that rather than a driver-specific debugfs
> interface.
>
You are right, this is why Sara made this commit:
commit 854d773e4ab5869200004af4ca5d851730849903
Author: Sara Sharon <sara.sharon@xxxxxxxxx>
Date: Tue Mar 22 15:55:58 2016 +0200
iwlwifi: mvm: improve RSS configuration
Improve current RSS configuration:
* Use netdev_rss_key instead of keeping a local copy.
* Configure also UDP hashing to have UDP traffic spread across queues.
* Do not direct RSS traffic to our fallback queue.
Signed-off-by: Sara Sharon <sara.sharon@xxxxxxxxx>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> Ben.��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
