Hi Dan, On Fri, Mar 18, 2016 at 10:01 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Fri, Mar 18, 2016 at 01:29:39PM +1100, Julian Calaby wrote: >> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >> >> Rename a jump label according to the current Linux coding style convention. >> >> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >> [Rewrote commit title] >> Signed-off-by: Julian Calaby <julian.calaby@xxxxxxxxx> >> >> --- >> >> This was controversial when introduced, however the change is obvious and >> harmless and is, in the worst case, just churn. >> >> I'm only including this as it meets my criteria for sheparding pending >> patches: it's sane, obviously correct or reviewable by me, and doesn't >> require any work to apply. >> >> This does meet those requirements, however given how controviersial it was >> when introduced, I'm not expecting people to be enthusiastic about >> applying it. >> >> Thanks, > > It's a bad idea to mark this sort of patch as controversial. It's > bikeshed stuff. Either apply it or don't but don't lets spend any more > time thinking about it. > > Actual controversial patches have a long term impact. Noted. I'll label anything like this (someone's done the work but it makes no difference if it's applied) as "bikeshed" or "churn" in the future. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
