Search Linux Wireless

Re: [PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 18, 2016 at 01:29:39PM +1100, Julian Calaby wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> 
> Rename a jump label according to the current Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> [Rewrote commit title]
> Signed-off-by: Julian Calaby <julian.calaby@xxxxxxxxx>
> 
> ---
> 
> This was controversial when introduced, however the change is obvious and
> harmless and is, in the worst case, just churn.
> 
> I'm only including this as it meets my criteria for sheparding pending
> patches: it's sane, obviously correct or reviewable by me, and doesn't
> require any work to apply.
> 
> This does meet those requirements, however given how controviersial it was
> when introduced, I'm not expecting people to be enthusiastic about
> applying it.
> 
> Thanks,

It's a bad idea to mark this sort of patch as controversial.  It's
bikeshed stuff.  Either apply it or don't but don't lets spend any more
time thinking about it.

Actual controversial patches have a long term impact.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux