Maya Erez <qca_merez@xxxxxxxxxxxxxxxx> writes: > From: Lior David <qca_liord@xxxxxxxxxxxxxxxx> > > Add module parameter oob_mode. Takes effect the next time > the interface is brought up and FW is loaded. Puts the FW > in special "out of the box" (OOB) mode which is used for > diagnostics and certification. > > Signed-off-by: Lior David <qca_liord@xxxxxxxxxxxxxxxx> > Signed-off-by: Maya Erez <qca_merez@xxxxxxxxxxxxxxxx> [...] > --- a/drivers/net/wireless/ath/wil6210/main.c > +++ b/drivers/net/wireless/ath/wil6210/main.c > @@ -27,6 +27,10 @@ bool debug_fw; /* = false; */ > module_param(debug_fw, bool, S_IRUGO); > MODULE_PARM_DESC(debug_fw, " do not perform card reset. For FW debug"); > > +static bool oob_mode; > +module_param(oob_mode, bool, S_IRUGO); > +MODULE_PARM_DESC(oob_mode, " enable OOB mode in FW"); The modparam descript doesn't really tell anything to the user, a parameter foo_mode with help text "enable foo" is useless :) Please add more informative message so that users have an idea what the parameter is about, without the need to check commit logs. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
