Maya Erez <qca_merez@xxxxxxxxxxxxxxxx> writes:
> From: Lior David <qca_liord@xxxxxxxxxxxxxxxx>
>
> Fix a debug message related to IOCTL that was incorrectly logged
> with the MISC category, and move it inside wil_ioctl so it will
> always be logged even if we call wil_ioctl from other places.
>
> Signed-off-by: Lior David <qca_liord@xxxxxxxxxxxxxxxx>
> Signed-off-by: Maya Erez <qca_merez@xxxxxxxxxxxxxxxx>
[...]
> --- a/drivers/net/wireless/ath/wil6210/ioctl.c
> +++ b/drivers/net/wireless/ath/wil6210/ioctl.c
> @@ -161,13 +161,20 @@ out_free:
>
> int wil_ioctl(struct wil6210_priv *wil, void __user *data, int cmd)
> {
> + int ret;
> +
> switch (cmd) {
> case WIL_IOCTL_MEMIO:
> - return wil_ioc_memio_dword(wil, data);
> + ret = wil_ioc_memio_dword(wil, data);
> + break;
> case WIL_IOCTL_MEMIO_BLOCK:
> - return wil_ioc_memio_block(wil, data);
> + ret = wil_ioc_memio_block(wil, data);
> + break;
> default:
> wil_dbg_ioctl(wil, "Unsupported IOCTL 0x%04x\n", cmd);
> return -ENOIOCTLCMD;
> }
> +
> + wil_dbg_ioctl(wil, "ioctl(0x%04x) -> %d\n", cmd, ret);
> + return ret;
> }
ioctl interfaces don't belong to wireless drivers and this should be
converted something else, like debugfs. I think there was a discussion
about this a year ago or so. I can take this patch still but please
replace this interface altogether.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
