Search Linux Wireless

mac80211: Possible bug in minstrel_ht when enabling RTS/CTS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

I think there might be a bug in the following code of minstrel_ht when deciding if RTS/CTS should be enabled:

   /* enable RTS/CTS if needed:
    * - if station is in dynamic SMPS (and streams > 1)
    * - for fallback rates, to increase chances of getting through
    */
   if (offset > 0 &&
       (mi->sta->smps_mode == IEEE80211_SMPS_DYNAMIC &&
        group->streams > 1)) {
       ratetbl->rate[offset].count = ratetbl->rate[offset].count_rts;
       flags |= IEEE80211_TX_RC_USE_RTS_CTS;
   }

The code does not match what it is said in the comment. RTS/CTS is not enabled for fallback rates when not in dynamic SMPS.

Regards.

Matías

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux