On 12/22/2015 10:01 AM, Linus Walleij wrote: > On Fri, Dec 18, 2015 at 7:01 PM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote: >> On 12/18/2015 07:27 AM, Rafał Miłecki wrote: >>> I'm afraid it wasn't tested on BCM47XX (MIPS) :( >> >> Yes, you are probably right. >> >>> On 14 August 2015 at 00:21, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote: >>>> @@ -218,9 +187,8 @@ int bcma_gpio_init(struct bcma_drv_cc *cc) >>>> chip->set = bcma_gpio_set_value; >>>> chip->direction_input = bcma_gpio_direction_input; >>>> chip->direction_output = bcma_gpio_direction_output; >>>> -#if IS_BUILTIN(CONFIG_BCM47XX) || IS_BUILTIN(CONFIG_ARCH_BCM_5301X) >>>> - chip->to_irq = bcma_gpio_to_irq; >>>> -#endif >>>> + chip->owner = THIS_MODULE; >>>> + chip->dev = bcma_bus_get_host_dev(bus); >>> >>> This assigns &bus->host_pdev->dev which is NULL. >> >> hmm, how do we fix this, as long as bcma does not have a device on mips >> this is a problem. Should we create a new device for mips? > > Yes I think MIPS should just create a host device. That > makes things simple and nice. Is it complex to do so? > > Yours, > Linus Walleij > Currently the documentation says this for the parent member on struct gpio_chip: * @parent: optional parent device providing the GPIOs I assume the optional is wrong here. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
