Search Linux Wireless

Re: [PATCH v3] bcma: switch GPIO portions to use GPIOLIB_IRQCHIP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm afraid it wasn't tested on BCM47XX (MIPS) :(

On 14 August 2015 at 00:21, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote:
> @@ -218,9 +187,8 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
>         chip->set               = bcma_gpio_set_value;
>         chip->direction_input   = bcma_gpio_direction_input;
>         chip->direction_output  = bcma_gpio_direction_output;
> -#if IS_BUILTIN(CONFIG_BCM47XX) || IS_BUILTIN(CONFIG_ARCH_BCM_5301X)
> -       chip->to_irq            = bcma_gpio_to_irq;
> -#endif
> +       chip->owner             = THIS_MODULE;
> +       chip->dev               = bcma_bus_get_host_dev(bus);

This assigns &bus->host_pdev->dev which is NULL.


> @@ -248,13 +216,13 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
>         else
>                 chip->base              = -1;
>
> -       err = bcma_gpio_irq_domain_init(cc);
> +       err = gpiochip_add(chip);
>         if (err)
>                 return err;
>
> -       err = gpiochip_add(chip);
> +       err = bcma_gpio_irq_init(cc);

This results in:
[    0.157054] missing gpiochip .dev parent pointer
(coming from gpiochip_irqchip_add) and
[    0.157287] bcma: bus0: Error registering GPIO driver: -22
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux