On 12/16/2015 11:29 PM, Michal Kazior wrote:
On 17 December 2015 at 00:50, Peter Oh <poh@xxxxxxxxxxxxxx> wrote:
On 12/16/2015 01:54 PM, Felix Fietkau wrote:
On 2015-12-16 22:19, Peter Oh wrote:
[...]
If mentioned to use the function to mesh frame only without touching
mac80211, then how do you suggest it to apply it only to mesh frame
without interfere other data frames?
Can you share your example?
It's trivial - in ath10k_tx you do this:
if (vif->type == NL80211_IFTYPE_MESH_POINT &&
skb->ip_summed == CHECKSUM_PARTIAL)
skb_checksum_help(skb);
Thank you Felix for the quick response.
I agree on your user experience opinion,
but what do you think when ath10k has a new chip supporting HW checksum for
Mesh?
You can simply introduce a fw-feature flag saying
"supports_mesh_csum_offload" later and skip the skb_checksum_help() if
it's set.
If we rely on fw-feature flag, then we are not able to use HW checksum
at all even for AP/STA interfaces.
Michał
Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
