Search Linux Wireless

Re: [PATCH] mac80211: rewrite fragmentation code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 07, 2008 at 01:22:19PM +0200, Johannes Berg wrote:
>
> +	if (unlikely(netif_queue_stopped(local->mdev) ||
> +		     __ieee80211_queue_stopped(local, control->queue)))
> +		return NETDEV_TX_BUSY;

Returning busy should be avoided because not everything expects it.
For example, this can cause tcpdump to see the same packet twice.

Besides, I'm not sure if this will even work if you're fiddling
with skb->next.  Perhaps you can stash it in a pointer local to
your device.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux