On Wed, Apr 30, 2008 at 02:40:58PM +0200, Johannes Berg wrote: > This patch makes mac80211 use the GSO infrastructure for segmentation, > but not really all of it because we do not register a protocol handler > (nor can do that easily since a lot of functions need to be done before > segmentation and another bunch afterwards, and we need to keep rcu- > protected structures for both.) Your idea of using skb_segment to remove duplicate code is great. However, using skb->gso_skb for the push-back doesn't work. For example, what is going to happen when I enable software GSO on a wireless device and then send a real GSO packet to it where each GSO fragment also required wireless fragmentation? I suggest that you just use skb_segment for the actual fragmentation but keep the original infrastructure for handling the fragments. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
