Hi Malcolm,
A couple of these comments apply to a few of the patches.
On Sun, Nov 22, 2015 at 8:07 PM, Malcolm Priestley <tvboxspy@xxxxxxxxx> wrote:
> Removing camel case and reflecting return value.
>
> Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx>
> ---
> drivers/staging/vt6655/rf.c | 138 ++++++++++++++++++++++----------------------
> 1 file changed, 69 insertions(+), 69 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index 4c22bb3..1c0691d 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -420,9 +420,9 @@ static bool s_bAL7230Init(struct vnt_private *priv)
> {
> void __iomem *dwIoBase = priv->PortOffset;
> int ii;
> - bool bResult;
> + bool ret;
>
> - bResult = true;
> + ret = true;
These two lines could be combined into one.
> /* 3-wire control for normal mode */
> VNSvOutPortB(dwIoBase + MAC_REG_SOFTPWRCTL, 0);
> @@ -432,7 +432,7 @@ static bool s_bAL7230Init(struct vnt_private *priv)
> BBvPowerSaveModeOFF(priv); /* RobertYu:20050106, have DC value for Calibration */
>
> for (ii = 0; ii < CB_AL7230_INIT_SEQ; ii++)
> - bResult &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[ii]);
> + ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTable[ii]);
Now that I understand why it's always ret &= ..., I'm truly horrified
by the error handling in this driver. =)
> /* PLL On */
> MACvWordRegBitsOn(dwIoBase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_SWPE3);
> @@ -616,26 +616,26 @@ bool RFbInit(
> struct vnt_private *priv
> )
> {
> - bool bResult = true;
> + bool ret = true;
>
> switch (priv->byRFType) {
> case RF_AIROHA:
> case RF_AL2230S:
> priv->byMaxPwrLevel = AL2230_PWR_IDX_LEN;
> - bResult = RFbAL2230Init(priv);
> + ret = RFbAL2230Init(priv);
> break;
> case RF_AIROHA7230:
> priv->byMaxPwrLevel = AL7230_PWR_IDX_LEN;
> - bResult = s_bAL7230Init(priv);
> + ret = s_bAL7230Init(priv);
> break;
> case RF_NOTHING:
> - bResult = true;
> + ret = true;
> break;
> default:
> - bResult = false;
> + ret = false;
> break;
> }
> - return bResult;
> + return ret;
> }
>
> /*
> @@ -654,26 +654,26 @@ bool RFbInit(
> bool RFbSelectChannel(struct vnt_private *priv, unsigned char byRFType,
> u16 byChannel)
> {
> - bool bResult = true;
> + bool ret = true;
>
> switch (byRFType) {
> case RF_AIROHA:
> case RF_AL2230S:
> - bResult = RFbAL2230SelectChannel(priv, byChannel);
> + ret = RFbAL2230SelectChannel(priv, byChannel);
> break;
> /*{{ RobertYu: 20050104 */
> case RF_AIROHA7230:
> - bResult = s_bAL7230SelectChannel(priv, byChannel);
> + ret = s_bAL7230SelectChannel(priv, byChannel);
> break;
> /*}} RobertYu */
> case RF_NOTHING:
> - bResult = true;
> + ret = true;
Isn't this line unnecessary?
> break;
> default:
> - bResult = false;
> + ret = false;
> break;
> }
> - return bResult;
> + return ret;
> }
>
> /*
> @@ -879,13 +879,13 @@ bool RFbRawSetPower(
> dwMax7230Pwr = 0x080C0B00 | ((byPwr) << 12) |
> (BY_AL7230_REG_LEN << 3) | IFREGCTL_REGW;
>
> - bResult &= IFRFbWriteEmbedded(priv, dwMax7230Pwr);
> + ret &= IFRFbWriteEmbedded(priv, dwMax7230Pwr);
> break;
>
> default:
> break;
You could remove this default case in another round of cleanups.
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
