Hi Malcolm,
On Sun, Nov 22, 2015 at 8:07 PM, Malcolm Priestley <tvboxspy@xxxxxxxxx> wrote:
> Removing camel case.
>
> Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx>
> ---
> drivers/staging/vt6655/channel.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
> index d1c9116..9ac1ef9 100644
> --- a/drivers/staging/vt6655/channel.c
> +++ b/drivers/staging/vt6655/channel.c
> @@ -176,10 +176,10 @@ void vnt_init_bands(struct vnt_private *priv)
> */
> bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
> {
> - bool bResult = true;
> + bool ret = true;
>
> if (priv->byCurrentCh == ch->hw_value)
> - return bResult;
> + return ret;
ret is always true here, right?
>
> /* Set VGA to max sensitivity */
> if (priv->bUpdateBBVGA &&
> @@ -200,8 +200,8 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
> ch->hw_value);
>
> priv->byCurrentCh = ch->hw_value;
> - bResult &= RFbSelectChannel(priv, priv->byRFType,
> - ch->hw_value);
> + ret &= RFbSelectChannel(priv, priv->byRFType,
> + ch->hw_value);
Isn't a &= b equivalent to a = a & b which is inappropriate for
boolean variables?
Also, wouldn't ret be true here, so the & is unnecessary?
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
