Search Linux Wireless

Re: [PATCH] mac80211: remove string from unaligned packet warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

[auto build test ERROR on mac80211/master]
[also build test ERROR on v4.3 next-20151106]

url:    https://github.com/0day-ci/linux/commits/Johannes-Berg/mac80211-remove-string-from-unaligned-packet-warning/20151106-190240
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

   In file included from arch/xtensa/include/generated/asm/bug.h:1:0,
                    from include/linux/bug.h:4,
                    from include/linux/thread_info.h:11,
                    from include/asm-generic/preempt.h:4,
                    from arch/xtensa/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/jiffies.h:7,
                    from net/mac80211/rx.c:13:
   net/mac80211/rx.c: In function 'ieee80211_verify_alignment':
>> include/asm-generic/bug.h:74:72: error: expected expression before ')' token
    #define __WARN_printf(arg...) warn_slowpath_fmt(__FILE__, __LINE__, arg)
                                                                           ^
>> include/asm-generic/bug.h:97:3: note: in expansion of macro '__WARN_printf'
      __WARN_printf(format);     \
      ^
>> include/asm-generic/bug.h:124:7: note: in expansion of macro 'WARN'
      if (WARN(!__warned, format))    \
          ^
>> net/mac80211/rx.c:664:2: note: in expansion of macro 'WARN_ONCE'
     WARN_ONCE((unsigned long)rx->skb->data & 1);
     ^

vim +/WARN_ONCE +664 net/mac80211/rx.c

   648	 * architecture doesn't support efficient unaligned operations, mac80211
   649	 * will align the data.
   650	 *
   651	 * With A-MSDU frames, however, the payload data address must yield two modulo
   652	 * four because there are 14-byte 802.3 headers within the A-MSDU frames that
   653	 * push the IP header further back to a multiple of four again. Thankfully, the
   654	 * specs were sane enough this time around to require padding each A-MSDU
   655	 * subframe to a length that is a multiple of four.
   656	 *
   657	 * Padding like Atheros hardware adds which is between the 802.11 header and
   658	 * the payload is not supported, the driver is required to move the 802.11
   659	 * header to be directly in front of the payload in that case.
   660	 */
   661	static void ieee80211_verify_alignment(struct ieee80211_rx_data *rx)
   662	{
   663	#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
 > 664		WARN_ONCE((unsigned long)rx->skb->data & 1);
   665	#endif
   666	}
   667	
   668	
   669	/* rx handlers */
   670	
   671	static int ieee80211_is_unicast_robust_mgmt_frame(struct sk_buff *skb)
   672	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux