Search Linux Wireless

Re: [PATCH] mac80211: remove string from unaligned packet warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2015-11-06 11:59, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> This really should never happen except very early in the process
> of bringing up a new driver, at which point you'll have to add
> more debugging in the driver and this string isn't useful. Remove
> it and save some size (when it's even compiled in.)
> 
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> ---
>  net/mac80211/rx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
> index 8bae5de0dc44..78346e89e997 100644
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -661,8 +661,7 @@ static void ieee80211_parse_qos(struct ieee80211_rx_data *rx)
>  static void ieee80211_verify_alignment(struct ieee80211_rx_data *rx)
>  {
>  #ifdef CONFIG_MAC80211_VERBOSE_DEBUG
> -	WARN_ONCE((unsigned long)rx->skb->data & 1,
> -		  "unaligned packet at 0x%p\n", rx->skb->data);
> +	WARN_ONCE((unsigned long)rx->skb->data & 1);
Shouldn't this be WARN_ON_ONCE?

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux