On Fri, Oct 30, 2015 at 10:34:00AM +0100, Johannes Berg wrote: > > + * @NL80211_CMD_ABORT_SCAN: stop an ongoing scan. Returns -ENOENT if a scan is > > + * not running. > I think we might need to indicate in nl80211 exported capabilities > whether or not this command is available? > > The return code requirement should probably also be documented in > cfg80211.h, and the fact that you get a scan-done message should be > here as well. > > Or is that not necessary - i.e. no relevant races are possible - and > the function return can be void? The currently identified use cases do not seem to care much about the actual result of this command since there is going to be a wait for the scan completed event anyway and the call is not even used unless there is a known ongoing scan. As such, even the difference of a driver supporting this command or not is not that significant taken into account this is used only as an optimization to speed up the following operation when a long scan operation was in progress. Things work fine (though without that speed benefit) even if the driver does not support this. Anyway, making cfg80211 advertise whether the new command is available could obviously be done should someone come up with a use case that depends on knowing that the optimization is available. The wpa_supplicant patches I'm planning on pushing in as soon as the nl80211 command ID gets assigned are here: http://w1.fi/p/scan/ -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
