On Sat, Apr 26, 2008 at 7:10 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > It's a side product of testing a sparse patch by Linus Torvalds. > > > Compile tested only. > > > > > iv32 = data[hdr_len + 4] + > > > - (data[hdr_len + 5] >> 8) + > > > - (data[hdr_len + 6] >> 16) + > > > - (data[hdr_len + 7] >> 24); > > > + (data[hdr_len + 5] << 8) + > > > + (data[hdr_len + 6] << 16) + > > > + (data[hdr_len + 7] << 24); > > > > > > #ifdef CONFIG_TKIP_DEBUG > > > printk(KERN_DEBUG "TKIP encrypt: iv16 = 0x%04x, iv32 = 0x%08x\n", > > > > > > > > > > We've tested TKIP code well and I'm not sure we wouldn't pay attention > > to such mistake. > > But the code does look a bit fishy. I'm confused. It looks bad. Frankly Pavel's version looks more correct but as black box TKIP is working. Maybe we never tested more then 256 wrapparounds.... will need to dig into more Thanks Tomas > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
