Search Linux Wireless

Re: [PATCH RFT] tkip: fix iv32 calculation in ieee80211_get_tkip_key()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >  It's a side product of testing a sparse patch by Linus Torvalds.
> >  Compile tested only.

> >         iv32 = data[hdr_len + 4] +
> >  -               (data[hdr_len + 5] >> 8) +
> >  -               (data[hdr_len + 6] >> 16) +
> >  -               (data[hdr_len + 7] >> 24);
> >  +               (data[hdr_len + 5] << 8) +
> >  +               (data[hdr_len + 6] << 16) +
> >  +               (data[hdr_len + 7] << 24);
> >
> >   #ifdef CONFIG_TKIP_DEBUG
> >         printk(KERN_DEBUG "TKIP encrypt: iv16 = 0x%04x, iv32 = 0x%08x\n",
> >
> >
> 
> We've tested TKIP code well and I'm not sure we wouldn't pay attention
> to such mistake.

But the code does look a bit fishy. I'm confused.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux