Search Linux Wireless

Re: [PATCH 1/2] Support python 3 in utils/key2pub.py.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 22 July 2015 04:50:45 Stefan Lippers-Hollmann wrote:
> You omit $(pwd) from ./utils/key2pub.py, while /utils/key2pub.py
> won't exist.

Wow, that's a really bad mistake on my part.  It should indeed probably
be './utils/key2pub.py'.  I made this change after my general testing,
simply because emacs was undoing the execute bit every time I saved
key2pub.py.

It's not really a material change, so I'll probably just put it back the
way it was.

The rest of the patch is tested, I pinky-swear :)
 
> As little as I know about python packaging policies in Debian
> (and probably Fedora), /usr/bin/python is never supposed to point
> to python3 - afaik the interpreter should always be called python3
> there, so I don't really see how that's going to work there.

I'm not assuming that the system interpreter is any particular version:
key2pub.py has been modified so it runs under either 2.7 or 3.x.

Some more simplification might be possible if 2.7 support is dropped,
but not much, and I didn't want to rock the boat.

Thanks for the prompt review!

Taahir

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux