Search Linux Wireless

Re: [PATCH 1/2] Support python 3 in utils/key2pub.py.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On 2015-07-21, ahmed.taahir@xxxxxxxxx wrote:
> From: Taahir Ahmed <ahmed.taahir@xxxxxxxxx>
> 
> utils/key2pub.py can now be run under either python 2.7 or python 3.x.
> This required some minor syntactical changes as well as switching from
> M2Crypto to pycrypto, since M2Crypto doesn't support python 3.x.
[...]
> diff --git a/Makefile b/Makefile
> index a3ead30..65fc780 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -112,7 +112,7 @@ $(REG_BIN):
>  keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
>  	$(NQ) '  GEN ' $@
>  	$(NQ) '  Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
> -	$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
> +	$(Q) python /utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
[...]

Without having tested it, nor being that familiar with python coding,
but this hunk seems to be problematic on two accords.

You omit $(pwd) from ./utils/key2pub.py, while /utils/key2pub.py
won't exist.

As little as I know about python packaging policies in Debian
(and probably Fedora), /usr/bin/python is never supposed to point
to python3 - afaik the interpreter should always be called python3
there, so I don't really see how that's going to work there.

Sorry if I missed anything obvious, but these things just caught
my attention without having looked any deeper.

Regards
	Stefan Lippers-Hollmann
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux