Search Linux Wireless

Re: [PATCH] Reordering for better readability and consistency [EDT]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25 May 2015 at 09:37, Rahul Jain <rahul.jain@xxxxxxxxxxx> wrote:
> hello Wireless Community,

Hi :)


> Please find patch for review.
>
> From 328fb9d1b772788fc51e7f9bb21e57a1d91b0188 Mon Sep 17 00:00:00 2001
> From: Rahul Jain <rahul.jain@xxxxxxxxxxx>
> Date: Mon, 25 May 2015 12:02:12 +0530
> Subject: [PATCH] Reordering for better readability and consistency

You should prefix your patch subject. It's usually the easiest to
check git history to see what kind of prefix is usually used for the
code you edit, like:
git log net/wireless/util.c


> @@ -1340,10 +1340,7 @@ bool ieee80211_operating_class_to_band(u8 operating_class,
>         case 128 ... 130:
>                 *band = IEEE80211_BAND_5GHZ;
>                 return true;
> -       case 81:
> -       case 82:
> -       case 83:
> -       case 84:
> +       case 81 ... 84:
>                 *band = IEEE80211_BAND_2GHZ;
>                 return true;
>         case 180:

I guess there could be some better word than "Reordering" for this
change. I don't think you really reordered anything ;)

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux