Search Linux Wireless

re: rtlwifi: rtl8821ae: Move driver from staging to regular tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Larry Finger,

The patch 21e4b0726dc6: "rtlwifi: rtl8821ae: Move driver from staging
to regular tree" from Sep 22, 2014, leads to the following static
checker warning:

	drivers/net/wireless/rtlwifi/rtl8821ae/hw.c:2183 _rtl8821ae_set_media_status()
	warn: masked condition is always false. '(bt_msr & 252) == 3'

drivers/net/wireless/rtlwifi/rtl8821ae/hw.c
  2181          rtl_write_byte(rtlpriv, MSR, bt_msr);
  2182          rtlpriv->cfg->ops->led_control(hw, ledaction);
  2183          if ((bt_msr & 0xfc) == MSR_AP)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^
This condition is never true.  We mask out the 0xfc flags at the
beginning of the function.  MSR_AP is 0x3.

  2184                  rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
  2185          else
  2186                  rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
  2187  
  2188          return 0;
  2189  }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux