On 04/20/15 20:49, Rafał Miłecki wrote:
On 20 April 2015 at 19:12, Arend van Spriel<arend@xxxxxxxxxxxx> wrote:
On 04/20/15 13:26, Rafał Miłecki wrote:
On 17 April 2015 at 10:50, Arend van Spriel<arend@xxxxxxxxxxxx> wrote:
Another option is to add the parsing stuff in that nvram code and have an
api to get the appropriate portion based on pcie domain and bus number as
used in brcmf_fw_get_firmwares_pcie(). However, I would prefer to have
this
in the driver and not in arch specific code as there may be other
platforms
like our set-top boxes needing this.
This is some plan for the future I was lacking from the beginning. It
makes things more clear now, thanks.
You're welcome. Do you want to see this clarification in the commit message?
I don't really need that, I'm leaving it up to you :)
The last remaining question from me is if about this NVRAM validation
function (if it exists).
Ok. I can try to answer that one. The nvram parsing code in firmware.c
intends to do just that. So apart from stripping comments and whitespace
it validates each line and gives off a warning if a wrongly formatted
entry is found.
Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
