On 14 April 2015 at 20:10, Arend van Spriel <arend@xxxxxxxxxxxx> wrote: > From: Hante Meuleman <meuleman@xxxxxxxxxxxx> > > With PCIE it is possible to support multiple devices with the > same device type. They all load the same nvram file. In order to > support this the nvram can specify which part of the nvram is > for which pcie device. This patch adds support for these new > types of nvram files. I'm a bit unsure about this patch. Does it support NVRAM files that are already in use by any platform? Or are you trying to solve problem we hit with ARM routers like Netgear R8000? If you developed this patch to support e.g. Netgear R8000 I'm afraid it won't be really helpful. You won't be able to provide a single NVRAM file for all devices because of many differences between devices. I don't only mean different models, but even units. I believe these PCIe devices have to receive NVRAM with e.g. MAC address so you don't want to provide one file for all users. It means we'll need to develop some extra layer that will fetch *system* (SoC) NVRAM and translate it into a NVRAM file that will be stored in user space. Then this file will be loaded back into the kernel. So if this is about adding support for embedded devices, I'd prefer much more to simply use Linux's NVRAM driver to get all wanted entries. Other than that I'm a bit confused by the "pcie/" prefix you decided to use. Every Broadcom NVRAM I've seen was using pci/ prefix. Shouldn't you stick to this standard format? Switching to "pcie/" would require another translation when reading entries from system NVRAM. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
