Search Linux Wireless

RE: [PATCH 1/2] cfg80211: Allow NL80211_ATTR_IFINDEX to be added to vendor events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> +/**
>> + * cfg80211_vendor_event_alloc_ext - allocate vendor-specific event 
>> +skb
>> + * @wiphy: the wiphy
>> + * @event_idx: index of the vendor event in the wiphy's vendor_events
>> + * @approxlen: an upper bound of the length of the data that will
>> + *	be put into the skb
>> + * @gfp: allocation flags
>> + * @wdev: the wireless device
>> + *
>> + * This function allocates and pre-fills an skb for an event on the
>> + * vendor-specific multicast group. This is otherwise identical to
>> + * cfg80211_vendor_event_alloc(), but ifindex of the specified 
>> +wireless device
>> + * is added to the event message before the vendor data attribute.
>> + *
>> + * When done filling the skb, call cfg80211_vendor_event() with the
>> + * skb to send the event.
> + *
> + * Return: An allocated and pre-filled skb. %NULL if any errors happen.
> + */
> +static inline struct sk_buff *
> +cfg80211_vendor_event_alloc_ext(struct wiphy *wiphy, int approxlen,
> +				int event_idx, gfp_t gfp,
> +				struct wireless_dev *wdev)
> +{
> +	return __cfg80211_alloc_event_skb(wiphy, NL80211_CMD_VENDOR,
> +					  NL80211_ATTR_VENDOR_DATA,
> +					  event_idx, approxlen, gfp, wdev);
>  }

> This doesn't seem necessary, why not just update the original function to add and document the new optional argument?

>[however, in the unlikely even that you can convince me otherwise we may have to add this to the documentation?]

This means that this kernel change can't be pulled in without corresponding driver changes to call  cfg80211_vendor_event_alloc() with a NULL for wdev. Please confirm if this is acceptable; otherwise, we would need to use the new wrapper defined above.

Thanks,
Ahmad Kholaif
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux